From: Alexander Larsson Date: Wed, 16 Sep 2020 13:54:03 +0000 (+0200) Subject: signatures: Fix leak in _sign_detached_metadata_append() X-Git-Tag: archive/raspbian/2022.1-3+rpi1~1^2~4^2~7^2~1^2 X-Git-Url: https://dgit.raspbian.org/%22http:/www.example.com/cgi/%22https:/www.github.com/%22bookmarks:///%22http:/www.example.com/cgi/%22https:/www.github.com/%22bookmarks:/?a=commitdiff_plain;h=2e9db809b9675585296ef410d5af4d84f9074101;p=ostree.git signatures: Fix leak in _sign_detached_metadata_append() This needs to ref_sink the returned variant, as it is used with g_autoptr in the callers. --- diff --git a/src/libostree/ostree-sign.c b/src/libostree/ostree-sign.c index ee7e928d..eeef96dd 100644 --- a/src/libostree/ostree-sign.c +++ b/src/libostree/ostree-sign.c @@ -365,7 +365,7 @@ _sign_detached_metadata_append (OstreeSign *self, signature_key, g_variant_builder_end (signature_builder)); - return g_variant_dict_end (&metadata_dict); + return g_variant_ref_sink (g_variant_dict_end (&metadata_dict)); } /**